[webkit-reviews] review granted: [Bug 51171] [GTK] Wrong check in ResourceHandleSoup in error cases : [Attachment 76744] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 16 07:34:16 PST 2010


Martin Robinson <mrobinson at webkit.org> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 51171: [GTK] Wrong check in ResourceHandleSoup in error cases
https://bugs.webkit.org/show_bug.cgi?id=51171

Attachment 76744: Patch
https://bugs.webkit.org/attachment.cgi?id=76744&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76744&action=review

> WebCore/platform/network/soup/ResourceHandleSoup.cpp:-512
>	       // WebCore might have cancelled the job in the while
> -	       if (!d->m_cancelled && soupMsg->response_body->data)

Better leave a comment here before landing this which explains the issue.


More information about the webkit-reviews mailing list