[webkit-reviews] review denied: [Bug 51174] Web Inspector: status message isn't shown in call stack sidebar pane for native breakpoints : [Attachment 76748] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 16 06:05:39 PST 2010


Yury Semikhatsky <yurys at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 51174: Web Inspector: status message isn't shown in call stack sidebar pane
for native breakpoints
https://bugs.webkit.org/show_bug.cgi?id=51174

Attachment 76748: Patch.
https://bugs.webkit.org/attachment.cgi?id=76748&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76748&action=review

> WebCore/inspector/front-end/BreakpointManager.js:181
> +	   this._lastHitBreakpointView = breakpointView;

Breakpoint manager shouldn't modify breakpoint views, instead each view should
listen to the corresponding breakpoint state changes and update itself.
BreakpointManager should operate on the breakpoints. r- for this.


More information about the webkit-reviews mailing list