[webkit-reviews] review granted: [Bug 51162] anchor the toolbar to the bottom of the diff if the diff doesn't take a full screen of height : [Attachment 76731] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 15 22:30:46 PST 2010
Adam Barth <abarth at webkit.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 51162: anchor the toolbar to the bottom of the diff if the diff doesn't
take a full screen of height
https://bugs.webkit.org/show_bug.cgi?id=51162
Attachment 76731: Patch
https://bugs.webkit.org/attachment.cgi?id=76731&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76731&action=review
I'm glad we have some one working on the review tool who actually, you know,
knows HTML+JavaScript+CSS. :)
> BugsSite/code-review.js:637
> + $(window).bind('resize', updateToolbarAnchorState);
Is this buggy if we're right on the boundary and someone adds an inline
comment? Or does that generate a resize event?
More information about the webkit-reviews
mailing list