[webkit-reviews] review granted: [Bug 50996] Consider disabling DNS prefetch when proxy is used : [Attachment 76700] updated patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 50996: Consider disabling DNS prefetch when proxy is used
https://bugs.webkit.org/show_bug.cgi?id=50996

Attachment 76700: updated patch
https://bugs.webkit.org/attachment.cgi?id=76700&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=76700&action=review

> WebCore/platform/network/cf/DNSCFNet.cpp:89
> +    RetainPtr<CFArrayRef> httpProxyArray =
CFNetworkCopyProxiesForURL(httpCFURL, proxySettings.get());
> +    RetainPtr<CFArrayRef> httpsProxyArray =
CFNetworkCopyProxiesForURL(httpsCFURL, proxySettings.get());

You need to adopt here since it’s a “copy”-style function.