[webkit-reviews] review requested: [Bug 51152] <select> elements don't honor border:0px in chromium-linux : [Attachment 76722] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 15 18:06:37 PST 2010


dgrogan at google.com has asked  for review:
Bug 51152: <select> elements don't honor border:0px in chromium-linux
https://bugs.webkit.org/show_bug.cgi?id=51152

Attachment 76722: Patch
https://bugs.webkit.org/attachment.cgi?id=76722&action=review

------- Additional Comments from dgrogan at google.com
This change makes selects larger to match their size in windows.  An example
test update is included in this patch.	Approximately 50 layout tests are
affected in the same manner as this example and will have to be rebaselined for
chromium-linux.

It looks like themeChromiumLinux.css was only added in order to avoid
rebaselining.  If so, and I'm about to take the rebaselining hit anyway, should
I delete it?  That would allow a lot of the affected tests' expected render
tree dumps (but not the pngs) in chromium-linux to be deleted because the
rebaselined dumps would match chromium-win.  I'm not sure if that's desired,
but it's an option.


More information about the webkit-reviews mailing list