[webkit-reviews] review granted: [Bug 51142] size status bubble to it's contents on the code review page : [Attachment 76693] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 15 15:23:38 PST 2010
Adam Barth <abarth at webkit.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 51142: size status bubble to it's contents on the code review page
https://bugs.webkit.org/show_bug.cgi?id=51142
Attachment 76693: Patch
https://bugs.webkit.org/attachment.cgi?id=76693&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76693&action=review
> BugsSite/code-review.js:259
> + $('.statusBubble')[0].style.height = e.data.height;
> + $('.statusBubble')[0].style.width = e.data.width;
This won't work in older browsers, but ok.
> BugsSite/code-review.js:289
> + // Can't append the HTML because we need to set the onload handler
before appending the iframe to the DOM.
> + statusBubble.onload = handleStatusBubbleLoad;
You could use a live event handler, but this seems fine.
More information about the webkit-reviews
mailing list