[webkit-reviews] review granted: [Bug 51087] WebKit2: Can't add files to an <input type=file> : [Attachment 76684] Updated Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 51087: WebKit2: Can't add files to an <input type=file>
https://bugs.webkit.org/show_bug.cgi?id=51087

Attachment 76684: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=76684&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=76684&action=review

> WebKit2/Scripts/webkit2/messages.py:420
> +	   'WebKit::WebOpenPanelParameters::Data':
'"WebOpenPanelParameters.h"',

I don't think this is needed.

> WebKit2/Shared/WebOpenPanelParameters.cpp:52
> +{

I usually name the out parameter "result" here.

> WebKit2/Shared/WebOpenPanelParameters.h:60
> +    WebOpenPanelParameters(const Data&);

Please make this explicit.

> WebKitTools/MiniBrowser/mac/BrowserWindowController.m:540
> +    printf("runOpenPanel callback\n");

Please remove this.