[webkit-reviews] review granted: [Bug 51051] commit-queue should upload failure diffs when tests flake : [Attachment 76672] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 51051: commit-queue should upload failure diffs when tests flake
https://bugs.webkit.org/show_bug.cgi?id=51051

Attachment 76672: Patch
https://bugs.webkit.org/attachment.cgi?id=76672&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76672&action=review

> WebKitTools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:449
> +	   if hasattr(file_or_string, 'read'):
> +	       return file_or_string

This is kind of a hack.

> WebKitTools/Scripts/webkitpy/tool/main.py:75
> +	   self.filesystem = FileSystem()

Nice.  This has been a long time coming.