[webkit-reviews] review granted: [Bug 45870] [reviewtool] should always show overall comments text box : [Attachment 76614] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 45870: [reviewtool] should always show overall comments text box
https://bugs.webkit.org/show_bug.cgi?id=45870

Attachment 76614: Patch
https://bugs.webkit.org/attachment.cgi?id=76614&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76614&action=review

I'm not sure happy with the new UI, but I think that's just because I fear
losing control of the reviewtool and not because of any real substantive issue.
 A couple nits below.  If you'd like to implement the auto-sizing of the status
bubble, that would be great.

> BugsSite/code-review.js:266
> +  function openOverallComments(e) {
> +    document.querySelector('.overallComments textarea').className = 'open';
> +    document.querySelector('#statusBubbleContainer').className = 'wrap';
> +  }

Should we use jQuery here?

> BugsSite/code-review.js:287
> +    document.querySelector('.overallComments
textarea').addEventListener('click', openOverallComments);

We really should use jQuery here.