[webkit-reviews] review granted: [Bug 51093] Refactor HTMLInputElement: Move a part of HTMLInputElement::defaultEventHandler() to InputTypes : [Attachment 76626] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 51093: Refactor HTMLInputElement: Move a part of
HTMLInputElement::defaultEventHandler() to InputTypes
https://bugs.webkit.org/show_bug.cgi?id=51093

Attachment 76626: Patch
https://bugs.webkit.org/attachment.cgi?id=76626&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76626&action=review

ok, with comments.

> WebCore/ChangeLog:10
> +	   renders, and the isindex form submission quirk code to InputTypes.

renders->renderers

> WebCore/html/HTMLInputElement.h:213
> +    void handleBeforeTextInsertedEvent(Event* event) {
InputElement::handleBeforeTextInsertedEvent(m_data, this, this, event); }

Darin would tell me to move this into HTMLInputElement.cpp :)