[webkit-reviews] review granted: [Bug 51105] Improve feArithmeticFilter : [Attachment 76643] patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Zoltan Herczeg
<zherczeg at webkit.org>'s request for review:
Bug 51105: Improve feArithmeticFilter
https://bugs.webkit.org/show_bug.cgi?id=51105

Attachment 76643: patch
https://bugs.webkit.org/attachment.cgi?id=76643&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76643&action=review

The code looks good. It's just sad, that you check m_type twice, but I also
don't see another way without code duplication :-/ r=me

Just one note, "feArithmeticFilter" is not the best choice. "Improve
'arithmetic' operator on feComposite" or something like that. And plese fix the
style issues.

> WebCore/ChangeLog:12
> +	   The existing tests cover this feature.

How, since you didn't change the behavior but just the performance?!? ;-)