[webkit-reviews] review granted: [Bug 49839] [Qt] Implement the File API spec : [Attachment 76624] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 15 07:07:21 PST 2010


Andreas Kling <kling at webkit.org> has granted Jarred Nicholls
<jarred.nicholls at gmail.com>'s request for review:
Bug 49839: [Qt] Implement the File API spec
https://bugs.webkit.org/show_bug.cgi?id=49839

Attachment 76624: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=76624&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76624&action=review

LGTM, just one thing:

> WebCore/platform/qt/FileSystemQt.cpp:181
> +	   return handle->seek(current += offset) ? current : -1;

This is a bit convoluted for my taste, please rewrite it in a more readable
way.


More information about the webkit-reviews mailing list