[webkit-reviews] review granted: [Bug 50493] Web Inspector: [Extension API] add support for adding/overriding HTTP request headers : [Attachment 76538] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 50493: Web Inspector: [Extension API] add support for adding/overriding
HTTP request headers
https://bugs.webkit.org/show_bug.cgi?id=50493

Attachment 76538: patch
https://bugs.webkit.org/attachment.cgi?id=76538&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76538&action=review

> WebCore/inspector/InspectorController.cpp:1833
> +	   m_overrideHeaders->add(it->first, value);

These are not necessarily "override" header since they are going to be
overriden by the network stack. "Extra" headers?