[webkit-reviews] review denied: [Bug 50422] [Qt] Canvas shadow offset should not be affected by any transformation : [Attachment 76620] Add changes in comment #27 fixing failing tests

[bugzilla-daemon at webkit.org]

Ariya Hidayat <ariya.hidayat at gmail.com> has denied Helder Correia
<helder at sencha.com>'s request for review:
Bug 50422: [Qt] Canvas shadow offset should not be affected by any
transformation
https://bugs.webkit.org/show_bug.cgi?id=50422

Attachment 76620: Add changes in comment #27 fixing failing tests
https://bugs.webkit.org/attachment.cgi?id=76620&action=review

------- Additional Comments from Ariya Hidayat <ariya.hidayat at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=76620&action=review

> WebCore/platform/graphics/qt/ContextShadowQt.cpp:139
> +    const FloatSize clippedOffset = m_unclippedLayerOrigin - m_layerOrigin;
> +    const float translationX = -layerArea.x() + frameSize -
abs(clippedOffset.width());
> +    const float translationY = -layerArea.y() + frameSize -
abs(clippedOffset.height());
> +    m_layerContext->translate(translationX, translationY);

Having both m_unclippedLayerOrigin and m_layerOrigin will be confusing. In
particular since we never need the former.

Here is an alternative: precompute the translation (as a point) in
calculateLayerBoundingRect and save it and the use it later here.