[webkit-reviews] review denied: [Bug 51046] Expose AccessibilityObject::url() to Chromium : [Attachment 76552] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 14 20:49:35 PST 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied
chris.guillory at google.com's request for review:
Bug 51046: Expose AccessibilityObject::url() to Chromium
https://bugs.webkit.org/show_bug.cgi?id=51046

Attachment 76552: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=76552&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76552&action=review

> WebKit/chromium/public/WebAccessibilityObject.h:113
> +    WEBKIT_API WebString url() const;

nit: we ordinarily expose urls using WebURL.  it looks like m_private->url() is
a KURL object.	(KURL can be implicitly converted to WebURL.)


More information about the webkit-reviews mailing list