[webkit-reviews] review denied: [Bug 49839] [Qt] Implement the File API spec : [Attachment 76422] Proposed patch

[bugzilla-daemon at webkit.org]

Ariya Hidayat <ariya.hidayat at gmail.com> has denied Jarred Nicholls
<jarred.nicholls at gmail.com>'s request for review:
Bug 49839: [Qt] Implement the File API spec
https://bugs.webkit.org/show_bug.cgi?id=49839

Attachment 76422: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=76422&action=review

------- Additional Comments from Ariya Hidayat <ariya.hidayat at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=76422&action=review

Some minor comments, otherwise LGTM.

> LayoutTests/ChangeLog:5
> +	   Allow File API (http://www.w3.org/TR/FileAPI/) to work w/ the Qt
port

Please match the single line description with the bug title.
Also, no need to shorten "with" to "w/".

> WebCore/features.pri:211
> +contains(DEFINES, ENABLE_3D_CANVAS=1): FEATURE_DEFINES_JAVASCRIPT +=
ENABLE_3D_CANVAS=1
> +contains(DEFINES, ENABLE_3D_RENDERING=1): FEATURE_DEFINES_JAVASCRIPT +=
ENABLE_3D_RENDERING=1

Is the change involving Canvas and Rendering also necessary?

> WebCore/platform/qt/FileSystemQt.cpp:98
> -    return String(QFileInfo(path).absolutePath());
> +    return QFileInfo(path).absolutePath();

Without this change, it won't work?