[webkit-reviews] review denied: [Bug 50799] Add Memory Sampler to WebKit : [Attachment 76157] patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied John Sullivan
<sullivan at apple.com>'s request for review:
Bug 50799: Add Memory Sampler to WebKit
https://bugs.webkit.org/show_bug.cgi?id=50799

Attachment 76157: patch
https://bugs.webkit.org/attachment.cgi?id=76157&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Since you don't want this setting to persist across launches of the
application, I don't think a preference is the way to go. Instead, the current
start/stop state should be stored as a variable, and toggling the setting
should send a message to WebKit to start or stop. 

WebKitMemorySampler::shared() should not allocate anything in the case where
nothing has been started -- that way, end users aren't impacted by this
developer-only tool.