[webkit-reviews] review requested: [Bug 49072] Loader cleanup : Simplify FrameLoader/DocumentLoader setupForReplace() : [Attachment 76585] Swap calls to writer()->end() and setupForReplace() in DocumentLoader

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 49072: Loader cleanup : Simplify FrameLoader/DocumentLoader
setupForReplace()
https://bugs.webkit.org/show_bug.cgi?id=49072

Attachment 76585: Swap calls to writer()->end() and setupForReplace() in
DocumentLoader
https://bugs.webkit.org/attachment.cgi?id=76585&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
Eric pointed me at some good resources for testing this content at
http://www.opentopia.com/hiddencam.php, which revealed a consistent crash.

writer()->end() needs to be before the call to setupForReplace(), because
setupForReplace() reverts the FrameLoader to provisional state, and
writer()->end() is assuming that the FrameLoader is committed.

Note that to trigger this codepath, you need to open one of the webcam feeds in
its own tab (i.e., as a main resource).