[webkit-reviews] review denied: [Bug 50398] Android would like to disable rounding hacks for TextRuns in text controls : [Attachment 76380] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 14 13:51:28 PST 2010


Dave Hyatt <hyatt at apple.com> has denied scroggo at google.com's request for
review:
Bug 50398: Android would like to disable rounding hacks for TextRuns in text
controls
https://bugs.webkit.org/show_bug.cgi?id=50398

Attachment 76380: patch
https://bugs.webkit.org/attachment.cgi?id=76380&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I really don't think of this as a RenderTheme setting.	I just think it's a
Setting.  That way it will be simple and non-virtual too.

It's not ok to add a member to InlineTextBoxes for this either.  That's too
much of a memory hit.

There's gotta be a way to avoid patching all of the text functions like that
too.


More information about the webkit-reviews mailing list