[webkit-reviews] review granted: [Bug 51005] Range::extractContents needs more tests : [Attachment 76559] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 14 13:02:00 PST 2010


Darin Adler <darin at apple.com> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 51005: Range::extractContents needs more tests
https://bugs.webkit.org/show_bug.cgi?id=51005

Attachment 76559: Patch
https://bugs.webkit.org/attachment.cgi?id=76559&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
It’s great to have more coverage.

However, textContent is an imprecise way to log the extracted fragment. These
tests would be stronger if they used something that shows the details of the
DOM nodes of the created fragment rather than just the concatenated text.

I think we have something for dumping markup that Ojan worked on a while back.
Or even outerHTML might be better?


More information about the webkit-reviews mailing list