[webkit-reviews] review granted: [Bug 51044] [V8] Get rid of delayed exception reporting in V8ConsoleMessage.cpp : [Attachment 76545] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 51044: [V8] Get rid of delayed exception reporting in V8ConsoleMessage.cpp
https://bugs.webkit.org/show_bug.cgi?id=51044

Attachment 76545: Patch
https://bugs.webkit.org/attachment.cgi?id=76545&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76545&action=review

Great.	I'm glad to be rid of this complexity.

> WebCore/bindings/v8/V8DOMWindowShell.cpp:102
> +    Document* document = frame->document();
> +    if (!document)
> +	   return;

document can never be null.

> WebCore/bindings/v8/V8DOMWindowShell.cpp:116
> +    String resourceNameString = useURL ? frame->document()->url() :
toWebCoreString(resourceName);

You've already got document in a local variable.  No need to go back to the
Frame.