[webkit-reviews] review denied: [Bug 49785] Move asynchronous event dispatching out of Document : [Attachment 74399] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 14 09:16:24 PST 2010


Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Mihai Parparita
<mihaip at chromium.org>'s request for review:
Bug 49785: Move asynchronous event dispatching out of Document
https://bugs.webkit.org/show_bug.cgi?id=49785

Attachment 74399: Patch
https://bugs.webkit.org/attachment.cgi?id=74399&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=74399&action=review

Looks ok overall, except for the win build fix mentioned.

> WebCore/WebCore.vcproj/WebCore.vcproj:42430
> +				RelativePath="..\dom\EventQueue.cpp"

I think you also need to add this file to DOMAllInOne for it to build on Win.


More information about the webkit-reviews mailing list