[webkit-reviews] review granted: [Bug 50635] [new-run-webkit-tests] expectations parsing is slow : [Attachment 76533] updated patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 50635: [new-run-webkit-tests] expectations parsing is slow
https://bugs.webkit.org/show_bug.cgi?id=50635

Attachment 76533: updated patch
https://bugs.webkit.org/attachment.cgi?id=76533&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76533&action=review

>
WebKitTools/Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:7
42
> +	       result = [test for test in self._full_test_list if
test.startswith(path)]

nit: I would make this an early return, then you can drop the "else:" line.

> WebKitTools/Scripts/webkitpy/layout_tests/port/test.py:214
> +	   if path.find('.') != -1:

This is fine for now given that this is just for testing, but in the real
webkit tree, we have the CSS2.1 directory, which we may want to add tests for
in the future. Please add a FIXME to make this work for that case.