[webkit-reviews] review denied: [Bug 39958] [Qt] TextBreakIteratorQt performance : [Attachment 76511] uploaded the patch again

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied  review:
Bug 39958: [Qt] TextBreakIteratorQt performance
https://bugs.webkit.org/show_bug.cgi?id=39958

Attachment 76511: uploaded the patch again
https://bugs.webkit.org/attachment.cgi?id=76511&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76511&action=review

> WebCore/ChangeLog:10
> +	   The previous fix for the performance improvement had a reference to
a
> +	   pointer which is deleted and hence the memcmp crashed. A check is
added
> +	   to validate the string is alive or not.

This still makes very little sense.

Do you actually know what you are trying to fix? We need a clear explanation of
what the problem is.
I admit I haven't looked at the issue closely yet but it's obvious that this is
fixing a symptom and not a root cause.

> WebCore/ChangeLog:15
> +	   This change will fix the crash while on panning and scrolling of a
page has many div tages.
> +	   Many testing are done w.r.t panning and scrolling on mobile phone
and emulator. Also this
> +	   is a sporadic crash hence performed manual regression tests to check
whether the crash is 
> +	   reproducible.

This adds no useful information and should be left out.