[webkit-reviews] review granted: [Bug 48858] Web Inspector: native breakpoints aren't hit on navigation : [Attachment 76399] Patch.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 48858: Web Inspector: native breakpoints aren't hit on navigation
https://bugs.webkit.org/show_bug.cgi?id=48858

Attachment 76399: Patch.
https://bugs.webkit.org/attachment.cgi?id=76399&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76399&action=review

> WebCore/inspector/front-end/BreakpointManager.js:36
> +	   this._stickyBreakpoints[projectId] =
this._validateBreakpoints(breakpoints[projectId]);

Why do we need this validation? No one else has access to the storage.

> WebCore/inspector/front-end/BreakpointManager.js:193
> +	       if (breakpoint.type ===
WebInspector.BreakpointManager.NativeBreakpointTypes.EventListener)

Why is there no branch for DOM breakpoints?