[webkit-reviews] review requested: [Bug 51021] Add JSRegExp.h to YARR : [Attachment 76520] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 14 02:44:47 PST 2010
Peter Varga <pvarga at inf.u-szeged.hu> has asked for review:
Bug 51021: Add JSRegExp.h to YARR
https://bugs.webkit.org/show_bug.cgi?id=51021
Attachment 76520: proposed patch
https://bugs.webkit.org/attachment.cgi?id=76520&action=review
------- Additional Comments from Peter Varga <pvarga at inf.u-szeged.hu>
This patch causes a style error:
JavaScriptCore/yarr/RegexCompiler.cpp:29: Found other header before a header
this file implements.
Should be: config.h, primary header, blank line, and then alphabetically
sorted. [build/include_order] [4]
The reason is the RegexCompiler.h contained just the decleration of the
compileRegex() function. I move it to the
new header: JSRegExp.h. I don't want to move any line from the
RegexCompiler.cpp to the RegexCompiler.h
therefore it became unnecessary.
More information about the webkit-reviews
mailing list