[webkit-reviews] review denied: [Bug 50990] Unused CSSRuleList vector in CSSParser class. : [Attachment 76460] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 14 00:56:00 PST 2010


Eric Seidel <eric at webkit.org> has denied Shane Stephens
<shanestephens at google.com>'s request for review:
Bug 50990: Unused CSSRuleList vector in CSSParser class.
https://bugs.webkit.org/show_bug.cgi?id=50990

Attachment 76460: Patch
https://bugs.webkit.org/attachment.cgi?id=76460&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76460&action=review

> WebCore/css/CSSRuleList.h:37
> +    CSSRuleList();

It would be better to use releaseRef() instead of exposing the constructor.


More information about the webkit-reviews mailing list