[webkit-reviews] review granted: [Bug 50666] Spatial Navigation: code clean up : [Attachment 76499] patch 4 - v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 13 22:37:21 PST 2010
Daniel Bates <dbates at webkit.org> has granted Antonio Gomes
<tonikitoo at webkit.org>'s request for review:
Bug 50666: Spatial Navigation: code clean up
https://bugs.webkit.org/show_bug.cgi?id=50666
Attachment 76499: patch 4 - v1
https://bugs.webkit.org/attachment.cgi?id=76499&action=review
------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76499&action=review
Looks good to me.
r=me.
> WebCore/page/FocusController.cpp:505
> + // spatial navigation algorithm to continue, skipping this
container.
Nit: I think it may be a bit clearer to write this line as "spatial navigation
algorithm will skip this container."
More information about the webkit-reviews
mailing list