[webkit-reviews] review denied: [Bug 50971] Combine setShadowHost and clearShadowHost into a simpler API : [Attachment 76446] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 50971: Combine setShadowHost and clearShadowHost into a simpler API
https://bugs.webkit.org/show_bug.cgi?id=50971

Attachment 76446: Patch
https://bugs.webkit.org/attachment.cgi?id=76446&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=76446&action=review

> WebCore/ChangeLog:5
> +	   Combine setShadowHost and clearShadowHost into a simpler API

You mean setShadowRoot and clearShadowRoot, right?

> WebCore/dom/Element.cpp:1093
> +    } else if (!newRoot)

I think this else is wrong.

> WebCore/dom/Element.cpp:1097
> +    newRoot->setShadowHost(this);

If hasRareData was true and newRoot is a null pointer, then we’ll dereference
the null pointer here.

> WebCore/dom/Node.h:220
> +    Element* shadowHost() const;
> +    void setShadowHost(Element*);

Why are you making these member functions public? Seems unrelated to the rest
of the patch?