[webkit-reviews] review granted: [Bug 51011] WebKit2: Need to be able to set the application name for the user agent for a WKPage : [Attachment 76496] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 13 21:45:42 PST 2010
Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 51011: WebKit2: Need to be able to set the application name for the user
agent for a WKPage
https://bugs.webkit.org/show_bug.cgi?id=51011
Attachment 76496: Patch
https://bugs.webkit.org/attachment.cgi?id=76496&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=76496&action=review
Maybe we should move the user agent computation code to WebCore so that it can
be shared between WebKit1 and WebKit2?
> WebKit2/UIProcess/WebPageProxy.cpp:631
> + return;
Doesn't seem like this check is needed here.
> WebKit2/UIProcess/WebPageProxy.h:404
> + static String standardUserAgent(const String& = String());
I think leaving out the parameter name here just leads to confusion.
More information about the webkit-reviews
mailing list