[webkit-reviews] review requested: [Bug 49953] [Qt] Focus rings are ugly, rects should be united instead of drawn individually : [Attachment 76487] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 13 19:16:41 PST 2010


Yael <yael.aharon at nokia.com> has asked	for review:
Bug 49953: [Qt] Focus rings are ugly, rects should be united instead of drawn
individually
https://bugs.webkit.org/show_bug.cgi?id=49953

Attachment 76487: Patch.
https://bugs.webkit.org/attachment.cgi?id=76487&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
Create a QPainterPath and add to it the focus rects, one at a time.
Combine the 2 drawFocusRing functions into one function drawFocusRingForPath.

Kling, the size of this patch is due to the images from the tests, code changes
are very small :-)


More information about the webkit-reviews mailing list