[webkit-reviews] review denied: [Bug 50985] [chromium] useless warnings when building on Windows : [Attachment 76451] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 13 17:29:26 PST 2010
Peter Kasting <pkasting at google.com> has denied Evan Martin
<evan at chromium.org>'s request for review:
Bug 50985: [chromium] useless warnings when building on Windows
https://bugs.webkit.org/show_bug.cgi?id=50985
Attachment 76451: Patch
https://bugs.webkit.org/attachment.cgi?id=76451&action=review
------- Additional Comments from Peter Kasting <pkasting at google.com>
The first warning has been discussed quite a bit in Chromium land and we've
repeatedly concluded we shouldn't disable it, but rather annotate safe uses,
because it does catch real bugs. I think the same should apply here.
I'm not sure what the second warning means. I'd like to understand better.
Help?
More information about the webkit-reviews
mailing list