[webkit-reviews] review denied: [Bug 50865] GlyphPage::fill() is slow on vertical writing (Mac) : [Attachment 76295] Propose patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 13 14:19:50 PST 2010
mitz at webkit.org has denied review:
Bug 50865: GlyphPage::fill() is slow on vertical writing (Mac)
https://bugs.webkit.org/show_bug.cgi?id=50865
Attachment 76295: Propose patch.
https://bugs.webkit.org/attachment.cgi?id=76295&action=review
------- Additional Comments from mitz at webkit.org
r-, actually. This is correct but I’d rather you didn’t add an anonymous
boolean parameter to isCJKIdeograph(). Instead, please rename it to
isCJKIdeographOrSymbol(), and factor out the isCJKIdeograph() part (and update
call sites).
More information about the webkit-reviews
mailing list