[webkit-reviews] review granted: [Bug 48545] Home/End, PgUp, PgDwn, spacebar, shift+spacebar, etc. should respect writing-mode : [Attachment 76418] Part 2: Patch for WebKit2 views.

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 48545: Home/End, PgUp, PgDwn, spacebar, shift+spacebar, etc. should respect
writing-mode
https://bugs.webkit.org/show_bug.cgi?id=48545

Attachment 76418: Part 2: Patch for WebKit2 views.
https://bugs.webkit.org/attachment.cgi?id=76418&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76418&action=review

> WebKit2/WebProcess/WebPage/mac/WebPageMac.mm:112
> +static inline void logicalScroll(Page* page, ScrollLogicalDirection
direction, ScrollGranularity granularity)
> +{
> +   
page->focusController()->focusedOrMainFrame()->eventHandler()->logicalScrollRec
ursively(direction, granularity);
> +}

Is anyone still calling the scroll() function above? Can we remove it?