[webkit-reviews] review granted: [Bug 50891] [GTK] Add API to enable/disable plugins at runtime : [Attachment 76325] pluginenable.diff

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 50891: [GTK] Add API to enable/disable plugins at runtime
https://bugs.webkit.org/show_bug.cgi?id=50891

Attachment 76325: pluginenable.diff
https://bugs.webkit.org/attachment.cgi?id=76325&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76325&action=review

Great stuff. Please fix the tiny style nits below before landing.

> WebKit/gtk/webkit/webkitwebplugin.cpp:67
> +static void webkit_web_plugin_get_property(GObject* object, guint prop_id,
GValue* value, GParamSpec* pspec)

Should be propertyId and paramSpec here.

> WebKit/gtk/webkit/webkitwebplugin.cpp:80
> +static void webkit_web_plugin_set_property(GObject* object, guint prop_id,
const GValue* value, GParamSpec *pspec)

Same here and the asterisk on pspec should be with GParamSpec.