[webkit-reviews] review granted: [Bug 48255] Stack overflow when there are too many sibling inline boxes : [Attachment 76400] Updated

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 13 10:27:34 PST 2010


Darin Adler <darin at apple.com> has granted Yong Li <yong.li.webkit at gmail.com>'s
request for review:
Bug 48255: Stack overflow when there are too many sibling inline boxes
https://bugs.webkit.org/show_bug.cgi?id=48255

Attachment 76400: Updated
https://bugs.webkit.org/attachment.cgi?id=76400&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
If our aim is to eliminate unnecessary recursion, it would be nice to walk the
entire tree without recursing. It’s good to eliminate recursing for each
sibling, yet this still recurses if children in turn have children. The trick
is to write a traversal function like Node::traverseNextNode or
RenderObject::nextInPreOrder and use it. If we do that we might also not want
setConstructed to be a virtual function any more.


More information about the webkit-reviews mailing list