[webkit-reviews] review granted: [Bug 50635] [new-run-webkit-tests] expectations parsing is slow : [Attachment 76377] updated patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 50635: [new-run-webkit-tests] expectations parsing is slow
https://bugs.webkit.org/show_bug.cgi?id=50635

Attachment 76377: updated patch
https://bugs.webkit.org/attachment.cgi?id=76377&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
I assume you ran the unittests for this. If not, please make sure to do so
before committing.

Also, it would be nice if you could add a test for this case. The closest thing
I could find was test_precedence, but that doesn't test the case of a file
being listed without it's parent directory also being listed. Minor edge case,
but more tests make me feel safer. :)