[webkit-reviews] review requested: [Bug 49658] [GTK] Simplify context-menu handling code : [Attachment 76364] New patch rebased to current master

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 13 03:00:26 PST 2010


Carlos Garcia Campos <cgarcia at igalia.com> has asked  for review:
Bug 49658: [GTK] Simplify context-menu handling code
https://bugs.webkit.org/show_bug.cgi?id=49658

Attachment 76364: New patch rebased to current master
https://bugs.webkit.org/attachment.cgi?id=76364&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
Rebased to current git master and fixing the crash in
editing/selection/empty-cell-right-click.html. It also improves the code that
connects the activate signal for the menu items. gtk_container_get_children()
uses gtk_container_foreach() to build the list of items, so we are iterating
twice, one to build the list and another one to connect the signal. Using
gtk_container_foreach() directly we iterate only once and we avoid
creating/destroying the GList. It also makes easier to connect the acivate
signal for submenu items.


More information about the webkit-reviews mailing list