[webkit-reviews] review denied: [Bug 47746] Respect charset in handleDataURL : [Attachment 74968] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 13 00:37:18 PST 2010


Eric Seidel <eric at webkit.org> has denied Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 47746: Respect charset in handleDataURL
https://bugs.webkit.org/show_bug.cgi?id=47746

Attachment 74968: Patch
https://bugs.webkit.org/attachment.cgi?id=74968&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
The ChangeLog needs to mention that this fixes 130 layout tests, and for which
port.  Otherwise the change looks fine.

(Every change requires a test, or explanation of why testing is impossible.) 
In this case, you have many tests, you just didn't explain that you're fixing
them (which is importnat both for reviewers and folks looking back through teh
svn history).


More information about the webkit-reviews mailing list