[webkit-reviews] review granted: [Bug 50896] WebKit2: Implement WebInspector::localizedStringsURL on Windows : [Attachment 76332] [PATCH] Fix

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 50896: WebKit2: Implement WebInspector::localizedStringsURL on Windows
https://bugs.webkit.org/show_bug.cgi?id=50896

Attachment 76332: [PATCH] Fix
https://bugs.webkit.org/attachment.cgi?id=76332&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=76332&action=review

> WebKit2/WebProcess/WebPage/win/WebInspectorWin.cpp:38
> +    RetainPtr<CFURLRef> htmlURLRef(AdoptCF,
CFBundleCopyResourceURL(CFBundleGetBundleWithIdentifier(CFSTR("com.apple.WebKit
")), CFSTR("localizedStrings"), CFSTR("js"), 0));
> +    if (!htmlURLRef)

The variable should be localizedStringsURLRef not htmlURLRef.

> WebKit2/WebProcess/WebPage/win/WebInspectorWin.cpp:41
> +    return String(CFURLGetString(htmlURLRef.get()));

Ditto.