[webkit-reviews] review denied: [Bug 39958] [Qt] TextBreakIteratorQt performance : [Attachment 76331] Fix for crash

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has denied Raju Kunnath
<raju.kunnath at nokia.com>'s request for review:
Bug 39958: [Qt] TextBreakIteratorQt performance
https://bugs.webkit.org/show_bug.cgi?id=39958

Attachment 76331: Fix for crash
https://bugs.webkit.org/attachment.cgi?id=76331&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76331&action=review

> WebCore/platform/text/qt/TextBreakIteratorQt.cpp:65
> +	   if (iterator.isValid() && type == iterator.type() && length ==
iterator.length && string == iterator.string
>	       && memcmp(string, iterator.string, length) == 0) {

This makes no sense.

If string == iterator.string, there's no point in calling memcmp(), and this
won't shield against dereferencing deleted pointers anyway, but rather add the
restriction that string and iterator.string must point to the same UChar array.