[webkit-reviews] review granted: [Bug 50892] [Qt][WK2] Crash in WebPage constructor. : [Attachment 76326] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 50892: [Qt][WK2] Crash in WebPage constructor.
https://bugs.webkit.org/show_bug.cgi?id=50892

Attachment 76326: Patch
https://bugs.webkit.org/attachment.cgi?id=76326&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76326&action=review

LGTM, except one small and one big thing:

> WebKit2/WebProcess/qt/WebProcessQt.cpp:47
> +    // Disable runtime enabled features that has no WebKit2 implementation
yet.

s/has/have/

> WebKit2/WebProcess/qt/WebProcessQt.cpp:53
> +    WebCore::RntimeEnabledFeatures::setSpeechInputEnabled(false);

s/Rntime/Runtime/