[webkit-reviews] review requested: [Bug 50885] [GTK] remove old data: URI handler, fix the SoupRequest-based one : [Attachment 76317] patch to use SoupRequestData

[bugzilla-daemon at webkit.org]

Dan Winship <danw at gnome.org> has asked	for review:
Bug 50885: [GTK] remove old data: URI handler, fix the SoupRequest-based one
https://bugs.webkit.org/show_bug.cgi?id=50885

Attachment 76317: patch to use SoupRequestData
https://bugs.webkit.org/attachment.cgi?id=76317&action=review

------- Additional Comments from Dan Winship <danw at gnome.org>
The comment about "limitations in KURL" in the old parseDataUrl() does not
appear to be relevant to the current code; the tests pass fine without lying
about the text encoding.

The changes to sendRequestCallback() are needed because the code was apparently
broken before; it worked for file URIs because they always had
!shouldContentSniff(), but for any other kind of non-HTTP URI it would result
in didReceiveResponse never being called.

The fixes to soup-request-data.c have already been committed to libsoup, but
this means that if we commit both this patch and bug 50675 then we need updated
libsoup packages on the bots, or else we'll have to temporarily skip a few
tests.