[webkit-reviews] review denied: [Bug 48255] Stack overflow when there are too many sibling inline boxes : [Attachment 72703] updated with much smaller test case

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 12 02:46:29 PST 2010


Eric Seidel <eric at webkit.org> has denied Andreas Kling <kling at webkit.org>'s
request for review:
Bug 48255: Stack overflow when there are too many sibling inline boxes
https://bugs.webkit.org/show_bug.cgi?id=48255

Attachment 72703: updated with much smaller test case
https://bugs.webkit.org/attachment.cgi?id=72703&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=72703&action=review

This needs an expectation file and should be dump as text.

> LayoutTests/fast/overflow/lots-of-sibling-inline-boxes.html:2
> +<html>
> +<body>

You dont' actually need these. :)

> LayoutTests/fast/overflow/lots-of-sibling-inline-boxes.html:4
> +<script>

This should be dumpAsText().

> LayoutTests/fast/overflow/lots-of-sibling-inline-boxes.html:9
> +</body>
> +</html>

Or these.  EOF newlines are nice for making diff not complain. :)


More information about the webkit-reviews mailing list