[webkit-reviews] review granted: [Bug 50881] Optimize FEGaussian blur : [Attachment 76312] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 11 22:39:12 PST 2010


Sam Weinig <sam at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 50881: Optimize FEGaussian blur
https://bugs.webkit.org/show_bug.cgi?id=50881

Attachment 76312: Patch
https://bugs.webkit.org/attachment.cgi?id=76312&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76312&action=review

> WebCore/ChangeLog:15
> +	   These changes giave a 1.42x performance improvement.

Typo: giave.

> WebCore/platform/graphics/filters/FEGaussianBlur.cpp:133
> +inline void boxBlurAlphaOnly(ByteArray* srcPixelArray, ByteArray*
dstPixelArray,
> +		       unsigned dx, int dxLeft, int dxRight, int stride, int
strideLine, int effectWidth, int effectHeight)

Weird alignment here.


More information about the webkit-reviews mailing list