[webkit-reviews] review granted: [Bug 50877] Web Inspector: Make inspector on Windows show and be usable in WebKit2 : [Attachment 76309] [PATCH] Fix

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 50877: Web Inspector: Make inspector on Windows show and be usable in
WebKit2
https://bugs.webkit.org/show_bug.cgi?id=50877

Attachment 76309: [PATCH] Fix
https://bugs.webkit.org/attachment.cgi?id=76309&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76309&action=review

> WebKit2/UIProcess/WebInspectorProxy.h:149
> +    WKViewRef m_inspectorView;

I think storing a RefPtr<WebView> here might make things a bit nicer.

> WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:100
> +	   case WM_SIZE:
> +	       lResult = onSizeEvent(hWnd, message, wParam, lParam, handled);
> +	       break;
> +	   case WM_GETMINMAXINFO:
> +	       lResult = onMinMaxInfoEvent(hWnd, message, wParam, lParam,
handled);
> +	       break;
> +	   case WM_CLOSE:
> +	       lResult = onCloseEvent(hWnd, message, wParam, lParam, handled);
> +	       break;
> +	   default:
> +	       handled = false;
> +	       break;

This should be un-indented.

> WebKit2/UIProcess/win/WebInspectorProxyWin.cpp:176
> +    CFStringRef urlStringRef = ::CFURLGetString(htmlURLRef.get());

We traditionally do not use the ::prefix on CF function calls.