[webkit-reviews] review denied: [Bug 50267] [Qt] Memory leaks for QWebPageClient : [Attachment 76240] updated with eric's suggestion

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied yi shen
<yi.4.shen at nokia.com>'s request for review:
Bug 50267: [Qt] Memory leaks for QWebPageClient
https://bugs.webkit.org/show_bug.cgi?id=50267

Attachment 76240: updated with eric's suggestion
https://bugs.webkit.org/attachment.cgi?id=76240&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76240&action=review

> WebKit/qt/Api/qwebpage.cpp:379
> +WebCore::PageClientQWidget* QWebPagePrivate::pageClientQWidget()

this is normally not how we do the cast wrappers. 

Somethink like

static PageClientQWidget* toPageClientQWidget(QWebPageClient* client)

you also want thwse to be inline

it just seems more appropriate adding a method like this to QWebViewPrivate.
like

PageClientQWidget* QWebViewPrivate::pageClient()