[webkit-reviews] review denied: [Bug 50867] [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6 : [Attachment 76297] a quick patch to make WebKitGtk+ build on Mac OS X
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Dec 11 06:58:39 PST 2010
Mark Rowe (bdash) <mrowe at apple.com> has denied Koan-Sin Tan
<koansin.tan at gmail.com>'s request for review:
Bug 50867: [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
https://bugs.webkit.org/show_bug.cgi?id=50867
Attachment 76297: a quick patch to make WebKitGtk+ build on Mac OS X
https://bugs.webkit.org/attachment.cgi?id=76297&action=review
------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
The changes in WebCore at the very least require explanation in the ChangeLog.
The change in UUID.cpp does not seem correct -- it looks as though it sends GTK
on Mac OS X down the “not implemented” path. Presumably if there is in fact a
reason for this change then the ChangeLog entry would mention it.
More information about the webkit-reviews
mailing list