[webkit-reviews] review granted: [Bug 35671] [Qt] Even if QNetworkRequest::AlwaysCache is set on a request, a page will be loaded from the network the first time : [Attachment 76261] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Jan Erik Hanssen
<jhanssen at gmail.com>'s request for review:
Bug 35671: [Qt] Even if QNetworkRequest::AlwaysCache is set on a request, a
page will be loaded from the network the first time
https://bugs.webkit.org/show_bug.cgi?id=35671

Attachment 76261: Patch
https://bugs.webkit.org/attachment.cgi?id=76261&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=76261&action=review

LGTM, two small things:

> WebKit/qt/tests/qwebframe/tst_qwebframe.cpp:3075
> +	   : QNetworkAccessManager(parent),
m_lastCacheLoad(QNetworkRequest::PreferNetwork)

Style, initializers should be on separate lines.

> WebKit/qt/tests/qwebframe/tst_qwebframe.cpp:3083
> +	       m_lastCacheLoad =
static_cast<QNetworkRequest::CacheLoadControl>(cacheLoad.toInt());

You're using toInt() here and toUInt() in QWebFrame::load().