[webkit-reviews] review granted: [Bug 47640] Clean up some DrawingBuffer issues from 69619 : [Attachment 70693] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 47640: Clean up some DrawingBuffer issues from 69619
https://bugs.webkit.org/show_bug.cgi?id=47640

Attachment 70693: Patch
https://bugs.webkit.org/attachment.cgi?id=70693&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=70693&action=review

Otherwise looks fine.

> WebCore/platform/graphics/gpu/DrawingBuffer.cpp:42
> +    OwnPtr<DrawingBuffer> drawingBuffer = adoptPtr(new
DrawingBuffer(context, size));
>      return (drawingBuffer->m_context) ? drawingBuffer.release() : 0;

I'm confused.  Isn't m_context jus the context we passed in?  Shouldn't we just
null check this and early return first?